AMBARI-26425: ambari admin sign out #3970
Open
shaur97 wants to merge 1 commit intoapache:frontend-refactorfrom
Open
AMBARI-26425: ambari admin sign out #3970shaur97 wants to merge 1 commit intoapache:frontend-refactorfrom
shaur97 wants to merge 1 commit intoapache:frontend-refactorfrom
Conversation
zRains
requested changes
Mar 30, 2025
| className="text-black m-0 breadcrumb d-flex align-items-center" | ||
| style={{ fontSize: 24 }} | ||
| > | ||
| {" "} |
| parseJSONData | ||
| } from "./api/Utility.ts"; | ||
| import { get } from "lodash"; | ||
| import AmbariAboutModal from "./AmbariAboutModal"; |
Comment on lines
+47
to
+52
| {showAmbariAboutModal ? ( | ||
| <AmbariAboutModal | ||
| isOpen={showAmbariAboutModal} | ||
| onClose={() => setShowAmbariAboutModal(false)} | ||
| /> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
My understanding is that isOpen alone can control the display and hiding of AmbariAboutModal. Why is an additional layer of render conditional wrapping needed?
| setInLocalStorage('ambari', encryptData(JSON.stringify(data))); | ||
|
|
||
| const headers = { | ||
| 'Authorization': 'Basic ' + 'invalid_username:password' |
Contributor
There was a problem hiding this comment.
The current ambari-server uses cookie-based authentication, but it seems you’ve implemented it using a JWT approach. What is the purpose of this here?
There was a problem hiding this comment.
@zRains this implementation logic seems to be as per angular js implementation of ambari-admin auth.js
jojochuang
changed the title
Contributor
|
Updated PR subject and retriggered precommit tests. Encountered rat failure: [INFO] Rat check: Summary over all files. Unapproved: 1, unknown: 1, generated: 0, approved: 181 licenses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.